Skip to content

fix: issue icons in published project link #6576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sriramveeraghanta merged 1 commit into from
Feb 10, 2025
Merged

fix: issue icons in published project link #6576

sriramveeraghanta merged 1 commit into from
Feb 10, 2025

Conversation

@gakshita
Copy link
Collaborator

@gakshita gakshita commented Feb 10, 2025 •
edited by coderabbitai bot
Loading

Description

This PR fixes the layout icons in project's published link

Summary by CodeRabbit

  • New Features
    • Upgraded the issues navigation with enhanced layout icons that dynamically adjust based on your selected view (list or board). This brings a more consistent and intuitive visual experience when toggling between different display modes.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

This update introduces a new component, IssueLayoutIcon, which renders different icons based on a layout prop. Additionally, the IssuesLayoutSelection component has been modified to import and use this new icon component instead of its previous dynamic icon rendering. The changes focus primarily on separating icon rendering logic into its own component.

Changes

File(s) Summary
space/core/components/issues/navbar/layout-icon.tsx New IssueLayoutIcon component added; uses a switch statement to render either a List or Kanban icon based on the layout prop, returning null for unrecognized layouts.
space/core/components/issues/navbar/layout-selection.tsx Updated IssuesLayoutSelection component to import and use IssueLayoutIcon (passing layout.key), replacing the older dynamic icon mechanism and removing the stroke width property.

Sequence Diagram(s)

sequenceDiagram
    participant LS as IssuesLayoutSelection
    participant LI as IssueLayoutIcon

    LS->>LI: Pass layout key prop (list/kanban)
    alt layout is "list"
        LI->>LI: Select and render List icon
    else layout is "kanban"
        LI->>LI: Select and render Kanban icon
    else
        LI->>LI: Return null (no icon)
    end
    LI-->>LS: Render chosen icon (or nothing)
Loading

Possibly related PRs

Suggested labels

🐛bug, 🌐frontend, 🎨UI / UX

Suggested reviewers

  • sriramveeraghanta
  • SatishGandham

Poem

I'm a happy little bunny in the code,
Hopping through changes on the digital road.
Layout icons now switch with flair,
Whether list or Kanban, they’re rendered with care.
A whimsical tweak in our tech burrow so fine,
Celebrating each change with a joyful rhyme!
🐰✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a2328d0 and 38e9335.

📒 Files selected for processing (2)
  • space/core/components/issues/navbar/layout-icon.tsx (1 hunks)
  • space/core/components/issues/navbar/layout-selection.tsx (2 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sriramveeraghanta sriramveeraghanta merged commit 1eb1e82 into preview Feb 10, 2025
9 of 12 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-issue-icons branch February 10, 2025 09:37
lifeiscontent pushed a commit that referenced this pull request Aug 18, 2025
@gakshita @lifeiscontent
fix: issue icons in published project link (#6576)
c7a39da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gakshita @sriramveeraghanta